Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 518047: Add missing stdio.h include for printf. (Closed)

Created:
10 years, 11 months ago by Craig
Modified:
9 years, 7 months ago
Reviewers:
Nico, Evan Martin, piman
CC:
chromium-reviews_googlegroups.com, greggman
Visibility:
Public.

Description

Add missing stdio.h include for printf. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35637

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
LG, but shouldn't this code use LOG instead of printf()?
10 years, 11 months ago (2010-01-06 18:36:43 UTC) #1
Craig
It probably does want to be turned into a LOG but I see there is ...
10 years, 11 months ago (2010-01-06 18:49:47 UTC) #2
Evan Martin
10 years, 11 months ago (2010-01-06 19:06:50 UTC) #3
Haha, Craig beat me to it!  And his fix has proper style, unlike the one I sent
to piman.

Powered by Google App Engine
This is Rietveld 408576698