Log the results of proxy resolution to LoadLog when "full logging mode" is en...

Log the results of proxy resolution to LoadLog when "full logging mode" is enabled.

Examples of what the logged text looks like:

  "Resolved proxy list: PROXY foobar:6233"
  "Resolved proxy list: DIRECT"
  "Resolved proxy list: PROXY foobar:80;SOCKS5 baz:1080;DIRECT"


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35749

[eroman, 2010-01-05 22:14:12]

http://codereview.chromium.org/518042/diff/1/3
File net/proxy/proxy_service.cc (right):

http://codereview.chromium.org/518042/diff/1/3#newcode275
net/proxy/proxy_service.cc:275: return FinishedResolvingProxy(result, rv,
load_log);
A side-effect of this is that RemoveBadProxies() gets called in the synchronous
completion case too. Seems like oversight that this wasn't being done before,
will add a unit-test for that in a follow-up changelist,

[wtc, 2010-01-07 19:41:50]

LGTM.

http://codereview.chromium.org/518042/diff/1/7
File net/base/load_log.h (right):

http://codereview.chromium.org/518042/diff/1/7#newcode149
net/base/load_log.h:149: 
Why do we need this static method, which is just the
non-static is_unbounded method with a null check?

http://codereview.chromium.org/518042/diff/1/4
File net/proxy/proxy_service.h (right):

http://codereview.chromium.org/518042/diff/1/4#newcode228
net/proxy/proxy_service.h:228: int FinishedResolvingProxy(ProxyInfo* result,
Our naming convention seems to use DidFinish... for such
functions.  Not a big deal.

[eroman, 2010-01-07 21:15:08]

http://codereview.chromium.org/518042/diff/1/7
File net/base/load_log.h (right):

http://codereview.chromium.org/518042/diff/1/7#newcode149
net/base/load_log.h:149: 
On 2010/01/07 19:41:50, wtc wrote:
> Why do we need this static method, which is just the
> non-static is_unbounded method with a null check?

This was just a convenience function to avoid the proliferation of NULL checks.
I could remove this, but I think it is reasonably in line with the other static
convenience functions.

http://codereview.chromium.org/518042/diff/1/4
File net/proxy/proxy_service.h (right):

http://codereview.chromium.org/518042/diff/1/4#newcode228
net/proxy/proxy_service.h:228: int FinishedResolvingProxy(ProxyInfo* result,
On 2010/01/07 19:41:50, wtc wrote:
> Our naming convention seems to use DidFinish... for such
> functions.  Not a big deal.

Done.

[wtc, 2010-01-07 21:24:42]

LGTM.