Fix our version of eventSender to handle keyLocation arg correctly.

Fix our version of eventSender to handle keyLocation arg correctly.

BUG=31360
TEST=LayoutTests/fast/events/keydown-numpad-keys.html

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35773

[kinuko, 2010-01-06 07:37:26]

Hi bono-san, here's a proposing patch to fix 31360.  Could you take a look at
it?
(small note: redefining DOM_KEY_LOCATION enum in the file is a bit ugly; I
wasn't sure the best place to have it / best way to refer the definition in
dom/KeyboardEvent.h)

Thanks,

[Hironori Bono, 2010-01-06 09:35:02]

Thank you for your change.
Would it be possible to remove the layout test fixed by this change from
"webkit/tools/layout_tests/test_expectations.txt" as listed in the following
diff?

Regards,

Hironori Bono

Index: src/webkit/tools/layout_tests/test_expectations.txt
===================================================================
--- src/webkit/tools/layout_tests/test_expectations.txt	(revision 35592)
+++ src/webkit/tools/layout_tests/test_expectations.txt	(working copy)
@@ -927,9 +927,6 @@
 // New in WebKit r52580.
 BUG31345 WIN LINUX : LayoutTests/svg/custom/mask-on-multiple-objects.svg =
IMAGE
 
-// New in WebKit r52608.
-BUG31360 : LayoutTests/fast/events/keydown-numpad-keys.html = TEXT
-
 // Text fails very rarely, 1/200 runs or fewer.
 BUG29737 LINUX DEBUG : LayoutTests/svg/W3C-SVG-1.1/filters-light-01-f.svg =
TEXT PASS
 BUG29737 MAC RELEASE : LayoutTests/svg/W3C-SVG-1.1/filters-light-01-f.svg =
TEXT PASS

[kinuko, 2010-01-06 10:26:11]

Thanks for reviewing, and oops, sure I should have updated the
test_expectations.txt as well.
Updated the patch.
Thanks!

On 2010/01/06 09:35:02, hbono wrote:
> Thank you for your change.
> Would it be possible to remove the layout test fixed by this change from
> "webkit/tools/layout_tests/test_expectations.txt" as listed in the following
> diff?
> 
> Regards,
> 
> Hironori Bono
> 
> Index: src/webkit/tools/layout_tests/test_expectations.txt
> ===================================================================
> --- src/webkit/tools/layout_tests/test_expectations.txt	(revision 35592)
> +++ src/webkit/tools/layout_tests/test_expectations.txt	(working copy)
> @@ -927,9 +927,6 @@
>  // New in WebKit r52580.
>  BUG31345 WIN LINUX : LayoutTests/svg/custom/mask-on-multiple-objects.svg =
> IMAGE
>  
> -// New in WebKit r52608.
> -BUG31360 : LayoutTests/fast/events/keydown-numpad-keys.html = TEXT
> -
>  // Text fails very rarely, 1/200 runs or fewer.
>  BUG29737 LINUX DEBUG : LayoutTests/svg/W3C-SVG-1.1/filters-light-01-f.svg =
> TEXT PASS
>  BUG29737 MAC RELEASE : LayoutTests/svg/W3C-SVG-1.1/filters-light-01-f.svg =
> TEXT PASS

[Hironori Bono, 2010-01-07 02:53:09]

LGTM with a nit.
Thank you for your change.

Regards,

Hironori Bono

http://codereview.chromium.org/518036/diff/1002/1004
File webkit/tools/test_shell/event_sending_controller.cc (right):

http://codereview.chromium.org/518036/diff/1002/1004#newcode222
webkit/tools/test_shell/event_sending_controller.cc:222: // Key event location
code as defined in DOM Level 3.
nit: "as defined" -> "introduced". It may be better to add the URL to the spec
for reference, i.e.
<http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents>

[kinuko, 2010-01-07 06:11:26]

Thanks!  I've updated the comment and am going to submit it (let me know if you
see any problems).

http://codereview.chromium.org/518036/diff/1002/1004
File webkit/tools/test_shell/event_sending_controller.cc (right):

http://codereview.chromium.org/518036/diff/1002/1004#newcode222
webkit/tools/test_shell/event_sending_controller.cc:222: // Key event location
code as defined in DOM Level 3.
On 2010/01/07 02:53:09, hbono wrote:
> nit: "as defined" -> "introduced". It may be better to add the URL to the spec
> for reference, i.e.
> <http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents>

Done.