Issue 518030: Merge 35371 - Fix up rowbytes vs. width desynchronization, and fix failure to...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 518030: Merge 35371 - Fix up rowbytes vs. width desynchronization, and fix failure to... (Closed)

Created:
10 years, 11 months ago by Chris Evans

Modified:
9 years, 6 months ago

Reviewers:
Chris Evans

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/branches/249/src/

Visibility:
Public.

Description

Merge 35371 - Fix up rowbytes vs. width desynchronization, and fix failure to initialize entire bitmap memory. To fix up the rowbytes value properly, we simply don't send it via IPC any more, and recalulate it from width and depth in the trusted code. It's a cheap calculation. Also one bonus fix: don't use an unintialized IconInfo if deserialization fails. BUG=31307 TEST=Manual; ran with breakpoints on the failure paths. Review URL: http://codereview.chromium.org/517023 TBR=jschuh@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35476

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	MM	chrome/common/common_param_traits.cc	View		2 chunks	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages