Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 518007: Simplify checking during allocation when Heap::always_allocate() is... (Closed)

Created:
11 years ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Simplify checking during allocation when Heap::always_allocate() is true. The rules are: 1. Heap::AllocateRaw can normally handle allocation requests in new space even when always_allocate() is true. It properly retries failed allocation in the second 'retry' space. 2. Heap::Allocate can normally handle allocation requests in new space. 3. We only need to check always_allocate() when explicitly requesting allocation in new space via Heap::new_space().AllocateRaw(). 4. The exception to these rules is fixed arrays with size such that MaxObjectSizeInPagedSpace < size <= MaxObjectSizeInNewSpace (ie, those that will be allocated in new space and promoted to large object space). They cannot be allocated in new space via Heap::Allocate or Heap::AllocateRaw, because the retry logic does not know to allocate extra remembered set bits when retrying in large object space. Committed: http://code.google.com/p/v8/source/detail?r=3535

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -76 lines) Patch
M src/heap.cc View 1 2 14 chunks +64 lines, -75 lines 0 comments Download
M src/heap-inl.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
10 years, 11 months ago (2010-01-04 12:19:34 UTC) #1
Erik Corry
10 years, 11 months ago (2010-01-05 10:49:35 UTC) #2
STV!

Powered by Google App Engine
This is Rietveld 408576698