Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 5178005: Rework the device management backend implementation. (Closed)

Created:
10 years, 1 month ago by Mattias Nissler (ping if slow)
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Rework the device management backend implementation. Introduce a service object that lives in the profile that hands out backends for the clients to use. Living in the profile also allows to make use of the profile's request context, which has the advantage over the independent request context implementation that stuff is more efficient (i.e. we need to only resolve the proxy once). BUG=none TEST=device_management_service_(unit|browser)test.cc Move DeviceManagementPolicyProvider into the profile. BUG=None TEST=existing unit tests succeed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1119 lines, -729 lines) Patch
chrome/browser/policy/configuration_policy_pref_store.h View 2 chunks +4 lines, -1 line 0 comments Download
chrome/browser/policy/configuration_policy_pref_store.cc View 5 chunks +16 lines, -17 lines 0 comments Download
chrome/browser/policy/device_management_backend_impl.h View 1 chunk +0 lines, -84 lines 0 comments Download
chrome/browser/policy/device_management_backend_impl.cc View 1 chunk +0 lines, -415 lines 0 comments Download
chrome/browser/policy/device_management_policy_provider.h View 4 chunks +11 lines, -18 lines 0 comments Download
chrome/browser/policy/device_management_policy_provider.cc View 7 chunks +19 lines, -33 lines 0 comments Download
chrome/browser/policy/device_management_policy_provider_unittest.cc View 3 chunks +7 lines, -2 lines 0 comments Download
chrome/browser/policy/device_management_service.h View 1 chunk +91 lines, -0 lines 0 comments Download
chrome/browser/policy/device_management_service.cc View 1 chunk +619 lines, -0 lines 0 comments Download
chrome/browser/policy/device_management_service_browsertest.cc View 7 chunks +28 lines, -21 lines 0 comments Download
chrome/browser/policy/device_management_service_unittest.cc View 14 chunks +121 lines, -28 lines 0 comments Download
chrome/browser/policy/device_token_fetcher.h View 4 chunks +8 lines, -0 lines 0 comments Download
chrome/browser/policy/device_token_fetcher.cc View 4 chunks +22 lines, -12 lines 0 comments Download
chrome/browser/policy/device_token_fetcher_unittest.cc View 4 chunks +11 lines, -3 lines 0 comments Download
chrome/browser/prefs/pref_notifier_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/prefs/pref_value_store.h View 4 chunks +21 lines, -8 lines 0 comments Download
chrome/browser/prefs/pref_value_store.cc View 3 chunks +9 lines, -4 lines 0 comments Download
chrome/browser/profile.h View 2 chunks +12 lines, -0 lines 0 comments Download
chrome/browser/profile.cc View 1 chunk +9 lines, -0 lines 0 comments Download
chrome/browser/profile_impl.h View 3 chunks +7 lines, -0 lines 0 comments Download
chrome/browser/profile_impl.cc View 5 chunks +49 lines, -0 lines 0 comments Download
chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
chrome/chrome_tests.gypi View 4 chunks +3 lines, -4 lines 0 comments Download
chrome/test/device_management_test_util.h View 1 chunk +0 lines, -15 lines 0 comments Download
chrome/test/device_management_test_util.cc View 1 chunk +0 lines, -33 lines 0 comments Download
chrome/test/test_url_request_context_getter.h View 1 chunk +33 lines, -0 lines 0 comments Download
chrome/test/testing_pref_service.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/test/testing_profile.h View 1 chunk +7 lines, -0 lines 0 comments Download
chrome/test/testing_profile.cc View 2 chunks +1 line, -20 lines 0 comments Download
net/tools/testserver/device_management.py View 1 chunk +7 lines, -7 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698