Issue 5177009: Remove the call to the alternate clear UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5177009: Remove the call to the alternate clear UI. (Closed)

Created:
10 years, 1 month ago by Raz Mathias

Modified:
9 years, 7 months ago

Reviewers:
csilv, tim (not reviewing)

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove the call to the alternate clear UI. BUG=63382 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67750

Patch Set 2 : Removed conditional #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	chrome/browser/ui/views/clear_browsing_data.cc	View	1	1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

csilv

http://codereview.chromium.org/5177009/diff/1/chrome/browser/ui/views/clear_browsing_data.cc File chrome/browser/ui/views/clear_browsing_data.cc (right): http://codereview.chromium.org/5177009/diff/1/chrome/browser/ui/views/clear_browsing_data.cc#newcode46 chrome/browser/ui/views/clear_browsing_data.cc:46: #if defined(OS_WIN) Driveby: Is there a reason to retain ...

10 years, 1 month ago (2010-11-22 19:49:17 UTC) #3

Raz Mathias

On 2010/11/22 19:49:17, csilv wrote: > http://codereview.chromium.org/5177009/diff/1/chrome/browser/ui/views/clear_browsing_data.cc > File chrome/browser/ui/views/clear_browsing_data.cc (right): > > http://codereview.chromium.org/5177009/diff/1/chrome/browser/ui/views/clear_browsing_data.cc#newcode46 > ...

10 years ago (2010-11-30 01:27:01 UTC) #4

LGTM++

Expand Messages | Collapse Messages

Issue 5177009: Remove the call to the alternate clear UI. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Removed conditional #

Messages