Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 5177009: Remove the call to the alternate clear UI. (Closed)

Created:
10 years, 1 month ago by Raz Mathias
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Remove the call to the alternate clear UI. BUG=63382 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67750

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed conditional #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome/browser/ui/views/clear_browsing_data.cc View 1 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Raz Mathias
10 years, 1 month ago (2010-11-22 18:24:57 UTC) #1
tim (not reviewing)
LGTM with green try pass.
10 years, 1 month ago (2010-11-22 18:30:44 UTC) #2
csilv
http://codereview.chromium.org/5177009/diff/1/chrome/browser/ui/views/clear_browsing_data.cc File chrome/browser/ui/views/clear_browsing_data.cc (right): http://codereview.chromium.org/5177009/diff/1/chrome/browser/ui/views/clear_browsing_data.cc#newcode46 chrome/browser/ui/views/clear_browsing_data.cc:46: #if defined(OS_WIN) Driveby: Is there a reason to retain ...
10 years, 1 month ago (2010-11-22 19:49:17 UTC) #3
Raz Mathias
On 2010/11/22 19:49:17, csilv wrote: > http://codereview.chromium.org/5177009/diff/1/chrome/browser/ui/views/clear_browsing_data.cc > File chrome/browser/ui/views/clear_browsing_data.cc (right): > > http://codereview.chromium.org/5177009/diff/1/chrome/browser/ui/views/clear_browsing_data.cc#newcode46 > ...
10 years ago (2010-11-30 01:27:01 UTC) #4
csilv
10 years ago (2010-11-30 18:29:55 UTC) #5
LGTM++

Powered by Google App Engine
This is Rietveld 408576698