Fix crash in web workers when entangled port sender is null.

Fix crash in web workers when entangled port sender is null.

BUG=63529
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66620

[inferno, 2010-11-18 04:39:45]

John, Dave, can you please review this one-liner null fix.

[levin, 2010-11-18 05:06:40]

http://codereview.chromium.org/5173005/diff/1/chrome/browser/worker_host/mess...
File chrome/browser/worker_host/message_port_dispatcher.cc (right):

http://codereview.chromium.org/5173005/diff/1/chrome/browser/worker_host/mess...
chrome/browser/worker_host/message_port_dispatcher.cc:202: 
John is the right person to review this and can hopefully check the code for
places with similar problems.

fwiw, this change has a memory leak.

A simple fix is to move this allocation inside of " if (entangled_port.sender)"
with entangled_port.sender->Send(ipc_msg);

[inferno, 2010-11-18 06:12:52]

Thanks Dave. Fixed it, also fixed another potential place.

John, can you please review.

http://codereview.chromium.org/5173005/diff/1/chrome/browser/worker_host/mess...
File chrome/browser/worker_host/message_port_dispatcher.cc (right):

http://codereview.chromium.org/5173005/diff/1/chrome/browser/worker_host/mess...
chrome/browser/worker_host/message_port_dispatcher.cc:202: 
On 2010/11/18 05:06:40, levin wrote:
> John is the right person to review this and can hopefully check the code for
> places with similar problems.
> 
> fwiw, this change has a memory leak.
> 
> A simple fix is to move this allocation inside of " if
(entangled_port.sender)"
> with entangled_port.sender->Send(ipc_msg);

Done.

[jam, 2010-11-18 07:41:36]

lgtm