Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 5173001: Changed the label for image screen according to mocks. (Closed)

Created:
10 years, 1 month ago by whywhat
Modified:
9 years, 7 months ago
Reviewers:
altimofeev
CC:
chromium-reviews, kenmoore_google.com, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Changed the label for image screen according to mocks. BUG=chromium-os:9248 TEST=Manually. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66617

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed layout for screen title #

Patch Set 3 : Better support for multi-line title #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_image_view.cc View 2 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
whywhat
10 years, 1 month ago (2010-11-17 13:41:58 UTC) #1
altimofeev
LGTM with nits: http://codereview.chromium.org/5173001/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/5173001/diff/1/chrome/app/generated_resources.grd#newcode3372 chrome/app/generated_resources.grd:3372: Smile! Take a picture of yourself ...
10 years, 1 month ago (2010-11-17 13:52:45 UTC) #2
whywhat
http://codereview.chromium.org/5173001/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/5173001/diff/1/chrome/app/generated_resources.grd#newcode3372 chrome/app/generated_resources.grd:3372: Smile! Take a picture of yourself and set it ...
10 years, 1 month ago (2010-11-17 13:56:24 UTC) #3
altimofeev
On 2010/11/17 13:56:24, whywhat wrote: > http://codereview.chromium.org/5173001/diff/1/chrome/app/generated_resources.grd > File chrome/app/generated_resources.grd (right): > > http://codereview.chromium.org/5173001/diff/1/chrome/app/generated_resources.grd#newcode3372 > ...
10 years, 1 month ago (2010-11-17 14:12:55 UTC) #4
whywhat
Could you take another look? I've added some real code changes to allow the title ...
10 years, 1 month ago (2010-11-17 19:46:15 UTC) #5
altimofeev
10 years, 1 month ago (2010-11-18 13:00:35 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698