chrome/browser/renderer_host/test/web_cache_manager_browsertest.cc - Issue 5172009: This adds some plumbing for propagating the reason for a renderer's death

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/test/web_cache_manager_browsertest.cc

Issue 5172009: This adds some plumbing for propagating the reason for a renderer's death (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Upload after sync for proper diffs Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/child_process_launcher.h ('K') | « chrome/browser/renderer_host/test/test_render_view_host.h ('k') | chrome/browser/tab_contents/interstitial_page.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/test/web_cache_manager_browsertest.cc

diff --git a/chrome/browser/renderer_host/test/web_cache_manager_browsertest.cc b/chrome/browser/renderer_host/test/web_cache_manager_browsertest.cc

index 06ce085c40015179a67a5e132622e828d75a6206..a878f6320cd7510b588d4d31f998bcef28c38f0d 100644

--- a/chrome/browser/renderer_host/test/web_cache_manager_browsertest.cc

+++ b/chrome/browser/renderer_host/test/web_cache_manager_browsertest.cc

@@ -33,7 +33,7 @@ IN_PROC_BROWSER_TEST_F(WebCacheManagerBrowserTest, FLAKY_CrashOnceOnly) {

TabContents* tab = browser()->GetTabContentsAt(0);

ASSERT_TRUE(tab != NULL);

base::KillProcess(tab->GetRenderProcessHost()->GetHandle(),

- base::PROCESS_END_KILLED_BY_USER, true);

+ base::EXIT_CODE_PROCESS_WAS_KILLED, true);

browser()->SelectTabContentsAt(0, true);

browser()->NewTab();