chrome/browser/task_manager/task_manager.cc - Issue 5172009: This adds some plumbing for propagating the reason for a renderer's death

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/task_manager.cc

Issue 5172009: This adds some plumbing for propagating the reason for a renderer's death (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Final review changes Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/task_manager/task_manager.cc

diff --git a/chrome/browser/task_manager/task_manager.cc b/chrome/browser/task_manager/task_manager.cc

index 2dc5029e16e3444fe565b4139a056b7a93bbd771..da19fda767b19d2d42c27cddd37a23a62efeb84d 100644

--- a/chrome/browser/task_manager/task_manager.cc

+++ b/chrome/browser/task_manager/task_manager.cc

@@ -26,6 +26,7 @@

#include "chrome/browser/tab_contents/tab_contents.h"

#include "chrome/browser/task_manager/task_manager_resource_providers.h"

#include "chrome/common/pref_names.h"

+#include "chrome/common/result_codes.h"

#include "chrome/common/url_constants.h"

#include "grit/app_resources.h"

#include "grit/chromium_strings.h"

@@ -944,7 +945,7 @@ void TaskManager::KillProcess(int index) {

base::ProcessHandle process = model_->GetResourceProcessHandle(index);

DCHECK(process);

if (process != base::GetCurrentProcessHandle())

- base::KillProcess(process, base::PROCESS_END_KILLED_BY_USER, false);

+ base::KillProcess(process, ResultCodes::KILLED, false);

}

void TaskManager::ActivateProcess(int index) {

« no previous file with comments | « chrome/browser/tab_contents/web_contents_unittest.cc ('k') | chrome/browser/utility_process_host.h » ('j') | no next file with comments »