chrome/browser/renderer_host/test/test_render_view_host.h - Issue 5172009: This adds some plumbing for propagating the reason for a renderer's death

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/test/test_render_view_host.h

Issue 5172009: This adds some plumbing for propagating the reason for a renderer's death (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Final review changes Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/render_widget_host_view_win.cc ('k') | chrome/browser/renderer_host/test/web_cache_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/test/test_render_view_host.h

diff --git a/chrome/browser/renderer_host/test/test_render_view_host.h b/chrome/browser/renderer_host/test/test_render_view_host.h

index 01ed8e4e8cb6558f2b3c498314fc747e991a55d9..85e185489ba799e5e8ffeb6bea8636538b51cc2c 100644

--- a/chrome/browser/renderer_host/test/test_render_view_host.h

+++ b/chrome/browser/renderer_host/test/test_render_view_host.h

@@ -83,7 +83,8 @@ class TestRenderWidgetHostView : public RenderWidgetHostView {

virtual void DidUpdateBackingStore(

const gfx::Rect& scroll_rect, int scroll_dx, int scroll_dy,

const std::vector<gfx::Rect>& rects) {}

- virtual void RenderViewGone() { delete this; }

+ virtual void RenderViewGone(base::TerminationStatus status,

+ int error_code) { delete this; }

virtual void WillDestroyRenderWidget(RenderWidgetHost* rwh) { }

virtual void Destroy() {}

virtual void PrepareToDestroy() {}