chrome/browser/renderer_host/render_widget_host_view_views.cc - Issue 5172009: This adds some plumbing for propagating the reason for a renderer's death

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_views.cc

Issue 5172009: This adds some plumbing for propagating the reason for a renderer's death (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Final review changes Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/render_widget_host_view_views.h ('k') | chrome/browser/renderer_host/render_widget_host_view_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/render_widget_host_view_views.cc

diff --git a/chrome/browser/renderer_host/render_widget_host_view_views.cc b/chrome/browser/renderer_host/render_widget_host_view_views.cc

index b9f386e1edaca70e98be452c1efbab4675ac6960..1cecddc1471fd7afade65ba9d2a281c863dd9a27 100644

--- a/chrome/browser/renderer_host/render_widget_host_view_views.cc

+++ b/chrome/browser/renderer_host/render_widget_host_view_views.cc

@@ -130,7 +130,8 @@ RenderWidgetHostViewViews::RenderWidgetHostViewViews(RenderWidgetHost* host)

}

RenderWidgetHostViewViews::~RenderWidgetHostViewViews() {

- RenderViewGone();

+ RenderViewGone(base::TERMINATION_STATUS_NORMAL_TERMINATION,

+ ResultCodes::NORMAL_EXIT);

}

void RenderWidgetHostViewViews::InitAsChild() {

@@ -285,7 +286,8 @@ void RenderWidgetHostViewViews::DidUpdateBackingStore(

}

-void RenderWidgetHostViewViews::RenderViewGone() {

+void RenderWidgetHostViewViews::RenderViewGone(base::TerminationStatus status,

+ int error_code) {

GetRenderWidgetHost()->ViewDestroyed();

Destroy();

}