chrome/browser/child_process_security_policy_browsertest.cc - Issue 5172009: This adds some plumbing for propagating the reason for a renderer's death

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/child_process_security_policy_browsertest.cc

Issue 5172009: This adds some plumbing for propagating the reason for a renderer's death (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Final review changes Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/child_process_security_policy_browsertest.cc

diff --git a/chrome/browser/child_process_security_policy_browsertest.cc b/chrome/browser/child_process_security_policy_browsertest.cc

index bedac819d2443da75fc28b9d2450d5e17c56593c..4bcd3dce577fced8781da62c45c363d0a0e3dcf3 100644

--- a/chrome/browser/child_process_security_policy_browsertest.cc

+++ b/chrome/browser/child_process_security_policy_browsertest.cc

@@ -11,6 +11,7 @@

#include "chrome/browser/renderer_host/render_process_host.h"

#include "chrome/browser/tab_contents/tab_contents.h"

#include "chrome/browser/ui/browser.h"

+#include "chrome/common/result_codes.h"

#include "chrome/test/in_process_browser_test.h"

#include "chrome/test/ui_test_utils.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -43,7 +44,7 @@ IN_PROC_BROWSER_TEST_F(ChildProcessSecurityPolicyInProcessBrowserTest, NoLeak) {

TabContents* tab = browser()->GetTabContentsAt(0);

ASSERT_TRUE(tab != NULL);

base::KillProcess(tab->GetRenderProcessHost()->GetHandle(),

- base::PROCESS_END_KILLED_BY_USER, true);

+ ResultCodes::KILLED, true);

tab->controller().Reload(true);

EXPECT_EQ(

« no previous file with comments | « chrome/browser/child_process_launcher.cc ('k') | chrome/browser/extensions/extension_crash_recovery_browsertest.cc » ('j') | no next file with comments »