chrome/browser/extensions/extension_crash_recovery_browsertest.cc - Issue 5172009: This adds some plumbing for propagating the reason for a renderer's death

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_crash_recovery_browsertest.cc

Issue 5172009: This adds some plumbing for propagating the reason for a renderer's death (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/process_util_unittest.cc ('K') | « chrome/browser/child_process_security_policy_browsertest.cc ('k') | chrome/browser/extensions/sandboxed_extension_unpacker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_crash_recovery_browsertest.cc

diff --git a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc

index 898de6b7a4b06c05c77575b3d1b05c416945c502..61e562dfcd2646f6ea4c8cd2988a003de9d4a943 100644

--- a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc

+++ b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc

@@ -62,7 +62,7 @@ class ExtensionCrashRecoveryTest : public ExtensionBrowserTest {

RenderProcessHost* extension_rph =

extension_host->render_view_host()->process();

base::KillProcess(extension_rph->GetHandle(),

- base::PROCESS_END_KILLED_BY_USER, false);

+ base::TERMINATION_STATUS_PROCESS_WAS_KILLED, false);

ASSERT_TRUE(WaitForExtensionCrash(extension_id));

ASSERT_FALSE(

GetExtensionProcessManager()->GetBackgroundHostForExtension(extension));