Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: chrome/browser/metrics/metrics_service.cc

Issue 5172009: This adds some plumbing for propagating the reason for a renderer's death (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Final review changes Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 6
7 //------------------------------------------------------------------------------ 7 //------------------------------------------------------------------------------
8 // Description of the life cycle of a instance of MetricsService. 8 // Description of the life cycle of a instance of MetricsService.
9 // 9 //
10 // OVERVIEW 10 // OVERVIEW
(...skipping 588 matching lines...) Expand 10 before | Expand all | Expand 10 after
599 break; 599 break;
600 600
601 case NotificationType::LOAD_STOP: 601 case NotificationType::LOAD_STOP:
602 LogLoadComplete(type, source, details); 602 LogLoadComplete(type, source, details);
603 break; 603 break;
604 604
605 case NotificationType::LOAD_START: 605 case NotificationType::LOAD_START:
606 LogLoadStarted(); 606 LogLoadStarted();
607 break; 607 break;
608 608
609 case NotificationType::RENDERER_PROCESS_CLOSED: 609 case NotificationType::RENDERER_PROCESS_CLOSED: {
610 {
611 RenderProcessHost::RendererClosedDetails* process_details = 610 RenderProcessHost::RendererClosedDetails* process_details =
612 Details<RenderProcessHost::RendererClosedDetails>(details).ptr(); 611 Details<RenderProcessHost::RendererClosedDetails>(details).ptr();
613 if (process_details->did_crash) { 612 if (process_details->status ==
613 base::TERMINATION_STATUS_PROCESS_CRASHED ||
614 process_details->status ==
615 base::TERMINATION_STATUS_ABNORMAL_TERMINATION) {
614 if (process_details->was_extension_renderer) { 616 if (process_details->was_extension_renderer) {
615 LogExtensionRendererCrash(); 617 LogExtensionRendererCrash();
616 } else { 618 } else {
617 LogRendererCrash(); 619 LogRendererCrash();
618 } 620 }
619 } 621 }
620 } 622 }
621 break; 623 break;
622 624
623 case NotificationType::RENDERER_PROCESS_HANG: 625 case NotificationType::RENDERER_PROCESS_HANG:
(...skipping 1282 matching lines...) Expand 10 before | Expand all | Expand 10 after
1906 thread_id = PlatformThread::CurrentId(); 1908 thread_id = PlatformThread::CurrentId();
1907 return PlatformThread::CurrentId() == thread_id; 1909 return PlatformThread::CurrentId() == thread_id;
1908 } 1910 }
1909 1911
1910 #if defined(OS_CHROMEOS) 1912 #if defined(OS_CHROMEOS)
1911 void MetricsService::StartExternalMetrics() { 1913 void MetricsService::StartExternalMetrics() {
1912 external_metrics_ = new chromeos::ExternalMetrics; 1914 external_metrics_ = new chromeos::ExternalMetrics;
1913 external_metrics_->Start(); 1915 external_metrics_->Start();
1914 } 1916 }
1915 #endif 1917 #endif
OLDNEW
« no previous file with comments | « chrome/browser/in_process_webkit/indexed_db_key_utility_client.cc ('k') | chrome/browser/nacl_host/nacl_process_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698