Issue 5172007: Update upload.py to r590.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5172007: Update upload.py to r590. (Closed)

Created:
10 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/third_party

Visibility:
Public.

Description

Update upload.py to r590. TBR=jam BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66776

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -38 lines)			Patch
	M	third_party/upload.py	View		10 chunks	+29 lines, -38 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

10 years, 1 month ago (2010-11-19 18:11:36 UTC) #2

lgtm

On Fri, Nov 19, 2010 at 10:06 AM, <maruel@chromium.org> wrote:

> Reviewers: John Abd-El-Malek,
>
> Description:
> Update upload.py to r590.
>
> TBR=jam
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/5172007/
>
> SVN Base: svn://
> svn.chromium.org/chrome/trunk/tools/depot_tools/third_party
>
> Affected files:
>  M third_party/upload.py
>
>
>

Expand Messages | Collapse Messages