Implement AutoFillProfile, a collection of form groups that stores profile in...

Implement AutoFillProfile, a collection of form groups that stores profile information.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35751

[jcampan, 2010-01-07 21:25:10]

Did you forget to add the autofill_profile files?

[James Hawkins, 2010-01-07 21:29:41]

Gah! sorry

[jcampan, 2010-01-07 21:59:41]

http://codereview.chromium.org/517066/diff/6002/6014
File chrome/browser/autofill/autofill_profile.cc (right):

http://codereview.chromium.org/517066/diff/6002/6014#newcode30
chrome/browser/autofill/autofill_profile.cc:30: FormGroupMap::iterator iter;
Consider using STLDeleteContainerPairSecondPointers (see stl_util-inl.h).
Or may better, could the map value be a scoped_ptr?

http://codereview.chromium.org/517066/diff/6002/6014#newcode39
chrome/browser/autofill/autofill_profile.cc:39: FieldTypeSet* possible_types)
const {
Indent is off.

http://codereview.chromium.org/517066/diff/6002/6015
File chrome/browser/autofill/autofill_profile.h (right):

http://codereview.chromium.org/517066/diff/6002/6015#newcode24
chrome/browser/autofill/autofill_profile.h:24: ~AutoFillProfile();
Make virtual.

http://codereview.chromium.org/517066/diff/6002/6015#newcode29
chrome/browser/autofill/autofill_profile.h:29: string16 GetFieldText(const
AutoFillType& type) const;
Shouldn't all the FormGroup methods be virtual?

[James Hawkins, 2010-01-07 22:26:54]

http://codereview.chromium.org/517066/diff/6002/6014
File chrome/browser/autofill/autofill_profile.cc (right):

http://codereview.chromium.org/517066/diff/6002/6014#newcode30
chrome/browser/autofill/autofill_profile.cc:30: FormGroupMap::iterator iter;
On 2010/01/07 21:59:41, jcampan wrote:
> Consider using STLDeleteContainerPairSecondPointers (see stl_util-inl.h).
> Or may better, could the map value be a scoped_ptr?

Per off-list, I'm going with STLDeleteContainerPairSecondPointers.

http://codereview.chromium.org/517066/diff/6002/6014#newcode39
chrome/browser/autofill/autofill_profile.cc:39: FieldTypeSet* possible_types)
const {
On 2010/01/07 21:59:41, jcampan wrote:
> Indent is off.

Done.

http://codereview.chromium.org/517066/diff/6002/6015
File chrome/browser/autofill/autofill_profile.h (right):

http://codereview.chromium.org/517066/diff/6002/6015#newcode24
chrome/browser/autofill/autofill_profile.h:24: ~AutoFillProfile();
On 2010/01/07 21:59:41, jcampan wrote:
> Make virtual.

Done.

http://codereview.chromium.org/517066/diff/6002/6015#newcode29
chrome/browser/autofill/autofill_profile.h:29: string16 GetFieldText(const
AutoFillType& type) const;
On 2010/01/07 21:59:41, jcampan wrote:
> Shouldn't all the FormGroup methods be virtual?

Done.

[jcampan, 2010-01-07 22:32:04]

LGTM