Issue 517065: Correct Chrome Frame dependencies such that a) CF tests depend on the CF DLL ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 517065: Correct Chrome Frame dependencies such that a) CF tests depend on the CF DLL ... (Closed)

Created:
10 years, 11 months ago by robertshield

Modified:
9 years, 6 months ago

Reviewers:
Nicolas Sylvain, slightlyoff

CC:
chromium-reviews_googlegroups.com, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Correct Chrome Frame dependencies such that a) CF tests depend on the CF DLL b) all.gyp:chromium_builder will build CF stuff. BUG=CF dll and chrome_launcher.exe were not getting built on the chromium-rel builder. TEST=No more BUG. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35788

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	build/all.gyp	View		1 chunk	+5 lines, -1 line	0 comments	Download
	M	chrome_frame/chrome_frame.gyp	View	1	4 chunks	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

robertshield

This should get the Chrome Frame binaries building correctly on the chromium-rel builder.

10 years, 11 months ago (2010-01-07 20:25:42 UTC) #1

lgtm

Expand Messages | Collapse Messages