Issue 517001: Revert 35189 (caused test_shell_tests crashes on valgrind bot):...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 517001: Revert 35189 (caused test_shell_tests crashes on valgrind bot):... (Closed)

Created:
11 years ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
Alexander Potapenko, Timur Iskhodzhanov

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, Lei Zhang

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 35189 (caused test_shell_tests crashes on valgrind bot): Take 2: Reenable TCMalloc on Linux and make POSIX signal handling async signal safe. Reinstates r34096 and r34036, which were reverted by r34632 due to hanging ui_tests and browser_tests on bots. I've been unable to repro on the trybots despite hitting them with a ton of try jobs, so I'm trying on the buildbots again. BUG=http://crbug.com/30501 Review URL: http://codereview.chromium.org/505068 TBR=willchan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35192

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -105 lines)			Patch
	M	build/common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/browser_main.cc	View		5 chunks	+31 lines, -104 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

Output is at http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Linux%20(valgrind)/builds/8162/steps/valgrind%20test:%20test_shell/logs/stdio and http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Linux%20(valgrind)/builds/8163/steps/valgrind%20test:%20test_shell/logs/stdio My changelist turned on tcmalloc for linux again, but ...

11 years ago (2009-12-23 00:14:56 UTC) #2

willchan no longer on Chromium

11 years ago (2009-12-23 00:22:37 UTC) #3

On 2009/12/23 00:14:56, willchan wrote:
> Output is at
>
http://build.chromium.org/buildbot/waterfall/builders/Webkit%2520Linux%2520%2...
> and
>
http://build.chromium.org/buildbot/waterfall/builders/Webkit%2520Linux%2520%2...
> 
> My changelist turned on tcmalloc for linux again, but I thought timurrrr
changed
> the valgrind bots so that tcmalloc wouldn't run on them.  Did this one get
> missed?  Or is there anything else going on?

Oops, I got the people switched around.  Looks like glider did this.  I'm still
not sure why tcmalloc is getting run on this bot though.

Expand Messages | Collapse Messages