Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1349)

Unified Diff: mod_for_factory_scripts/500populateQualDbs

Issue 5168001: cros_utils: refine factory and imaging related scripts (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crosutils.git@master
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mod_for_factory_scripts/500populateQualDbs
diff --git a/mod_for_factory_scripts/500populateQualDbs b/mod_for_factory_scripts/500populateQualDbs
index fff9a05642290e05285b1fb554a9cc351d828fc0..4424f641255857d6ece3476754b564c0346fd022 100755
--- a/mod_for_factory_scripts/500populateQualDbs
+++ b/mod_for_factory_scripts/500populateQualDbs
@@ -6,16 +6,25 @@
TEST_DIR="${ROOT_FS_DIR}/usr/local/autotest/site_tests/hardware_Components"
-pushd ${TEST_DIR} 1> /dev/null
+pushd "${TEST_DIR}" >/dev/null
Nick Sanders 2010/11/18 05:12:08 Can you check for existence of dir
Hung-Te 2010/11/18 05:49:31 Just saw you've created another refine for that -
Nick Sanders 2010/11/18 05:12:08 Can you also clean 600xxx in mod_for_factory
Hung-Te 2010/11/18 05:49:31 Added in latest CL.
# Remove the DB directories belonging to other boards.
KEEPDB="data_${BOARD}"
-ls -d data_* 2> /dev/null | grep -v ${KEEPDB} | xargs rm -fr
+ls -d data_* 2>/dev/null | grep -v "${KEEPDB}" | xargs rm -fr
-# Ensure there is DB directory in x86-agz and x86-mario.
-if [ ! -d ${KEEPDB} -a \
- \( "${BOARD}" = "x86-agz" -o "${BOARD}" = "x86-mario" \) ]; then
- echo "No component DB directory found at: ${KEEPDB}"
-fi
+# Ensure there is DB directory in authorized list
+case "${BOARD}" in
+ x86-agz | x86-mario )
+ if [ ! -d "${KEEPDB}" ]; then
+ echo "No component DB directory found at: ${KEEPDB}"
+ # TODO(hungte) should we exit as failure when the DB is missing?
+ fi
+ ;;
-popd 1> /dev/null
+ * )
+ # No need to check for unknown boards
+ true
+ ;;
+esac
+
+popd >/dev/null

Powered by Google App Engine
This is Rietveld 408576698