mod_for_factory_scripts/factory_setup.sh - Issue 5168001: cros_utils: refine factory and imaging related scripts

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mod_for_factory_scripts/factory_setup.sh

Issue 5168001: cros_utils: refine factory and imaging related scripts (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 #!/bin/bash	1 #!/bin/bash

2	2

3 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.	3 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.

4 # Use of this source code is governed by a BSD-style license that can be	4 # Use of this source code is governed by a BSD-style license that can be

5 # found in the LICENSE file.	5 # found in the LICENSE file.

6	6

7 echo "Modifying image for factory test..."	7 echo "Modifying image for factory test..."

	8 set -e

8	9

9 for SCRIPT in \	10 SCRIPT_BASE="${GCLIENT_ROOT}/src/scripts/mod_for_factory_scripts/"

10 ${GCLIENT_ROOT}/src/scripts/mod_for_factory_scripts/[0-9][0-9][0-9]*[!$~]	11 for SCRIPT in "${SCRIPT_BASE}"[0-9][0-9][0-9]*[!$~]
	Tom Wai-Hong Tam 2010/11/18 04:25:50 How about quote the whole pattern, like "${SCRIPT_ How about quote the whole pattern, like "${SCRIPT_BASE}[0-9][0-9][0-9][!$~]"? Hung-Te* 2010/11/18 05:49:31 You can't do that. * in quote won't be expanded. You can't do that. * in quote won't be expanded.
11 do	12 do

12 ${SCRIPT}	13 echo "Apply $(basename "${SCRIPT}")..."

	14 "${SCRIPT}"

13 done	15 done

OLD	NEW