Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 5167003: Merge 66631 - Mac: Only clear the background of CoreAnimation plugins if we'r... (Closed)

Created:
10 years, 1 month ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, pam+watch_chromium.org, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Merge 66631 - Mac: Only clear the background of CoreAnimation plugins if we're going to draw into them. Previously, the logic was: 1.) Clear plugin background 2.) If the plugin didn't update, return early 3.) Paint plugin 4.) "Swap buffers" But the "Swap buffers" step only unbound and rebound an FBO object If the plugin didn't change, its backing store would contain transparent black, and if the graphics driver decided to flush the FBO for another reason than a "swap buffers" call, the blackness would show up in the browser. This CL swaps steps 1 and 2, so even if the FBO is flushed for some unrelated reason, we display something valid. BUG=60341 TEST=Open the file attached to the bug. Resize the window for a few minutes, put the computer to sleep and back on, resize window for a few more minutes. The plugin area (the 191x60px rect in the middle) shouldn't become black. YouTube should still work. CPU usage shouldn't be worse than it was before for the browser, plugin, and renderer processes. Review URL: http://codereview.chromium.org/5220002 TBR=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M webkit/glue/plugins/webplugin_delegate_impl_mac.mm View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
10 years, 1 month ago (2010-11-18 18:14:46 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698