Issue 5166006: Untemplated preparser.h and made it depend on virtual types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5166006: Untemplated preparser.h and made it depend on virtual types. (Closed)

Created:
10 years, 1 month ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Untemplated preparser.h and made it depend on virtual types. Extracted preparse-data specification and logging classes.

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1656 lines, -1486 lines)			Patch
M	src/SConscript	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/parser.h	View	3 chunks	+7 lines, -144 lines	0 comments	Download
M	src/parser.cc	View	7 chunks	+37 lines, -156 lines	0 comments	Download
A	src/preparse-data.h	View	1 chunk	+223 lines, -0 lines	0 comments	Download
A	src/preparse-data.cc	View	1 chunk	+180 lines, -0 lines	0 comments	Download
M	src/preparser.h	View	4 chunks	+5 lines, -1183 lines	0 comments	Download
A	src/preparser.cc	View	1 chunk	+1184 lines, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-parsing.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/visual_studio/v8_base.vcproj	View	1 chunk	+16 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM