Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 5165001: crosutils: fix "umount: /tmp/XXX: not mounted" in build_image (Closed)

Created:
10 years, 1 month ago by Hung-Te
Modified:
9 years, 7 months ago
Reviewers:
Will Drewry
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

crosutils: fix "umount: /tmp/XXX: not mounted" in build_image The update_bootloaders needs to unmount file system first for syslinux to manipulate the raw device file, but the real "umount+losetup -d" in cleanup stage would cause failure. This CL remounts partition again so that cleanup can be executed successfully. BUG=chromium-os:9278 TEST=Manually executed ./build_image; Before fix: seeing "umount: /tmp/esp.2q8fSn: not mounted" in last page. After fix: no such error. The output image is verified to be bootable successfully. Change-Id: I19e2e062ad814e7bcd54777b5c3cee31f2b92e81 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=df4fc21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M update_bootloaders.sh View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Hung-Te
10 years, 1 month ago (2010-11-17 09:55:15 UTC) #1
Will Drewry
10 years, 1 month ago (2010-11-18 09:21:08 UTC) #2
LGTM - thanks!

Powered by Google App Engine
This is Rietveld 408576698