Chromium Code Reviews Chromium Code Reviews| Index: net/base/x509_cert_types_unittest.cc |
| diff --git a/net/base/x509_cert_types_unittest.cc b/net/base/x509_cert_types_unittest.cc |
| index 50012b12ec83bbe696554d75b8008da0cd3d80f2..44792457fb33036d46cc06aa06822855dde6b52c 100644 |
| --- a/net/base/x509_cert_types_unittest.cc |
| +++ b/net/base/x509_cert_types_unittest.cc |
| @@ -2,6 +2,7 @@ |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| +#include "base/basictypes.h" |
| #include "net/base/x509_cert_types.h" |
| #include "testing/gtest/include/gtest/gtest.h" |
| @@ -212,6 +213,7 @@ static const uint8 EntrustDN[] = { |
| namespace net { |
| +#if defined(OS_MACOSX) // These should only be implemented on Mac. |
|
bulach
2010/11/17 12:16:50
maybe we should rename this file to x509_cert_type
|
| TEST(X509TypesTest, Matching) { |
| CertPrincipal spamco; |
| spamco.common_name = "SpamCo Dept. Of Certificization"; |
| @@ -249,8 +251,6 @@ TEST(X509TypesTest, Matching) { |
| EXPECT_FALSE(spamco.Matches(bogus)); |
| } |
| -#if defined(OS_MACOSX) // ParseDistinguishedName not implemented for Win/Linux |
| - |
| TEST(X509TypesTest, ParseDNVerisign) { |
| CertPrincipal verisign; |
| EXPECT_TRUE(verisign.ParseDistinguishedName(VerisignDN, sizeof(VerisignDN))); |
| @@ -338,7 +338,6 @@ TEST(X509TypesTest, ParseDNEntrust) { |
| EXPECT_EQ("(c) 1999 Entrust.net Limited", |
| entrust.organization_unit_names[1]); |
| } |
| - |
| #endif |
|
wtc
2010/11/17 21:31:53
Nit: This ifdef spans a lot of code, so it would b
|
| -} |
| +} // namespace net |
