Change the order of evaluation of sub-expressions for keyed call...

Change the order of evaluation of sub-expressions for keyed call

The expression of the key is now evaluated before the arguments, so all expressions in a keyed call are evaluared from left to right.

BUG=http://code.google.com/p/v8/issues/detail?id=931
TEST=test/mjsunit/regress/regress-931.js

Committed: http://code.google.com/p/v8/source/detail?r=5842

[Søren Thygesen Gjesse, 2010-11-17 13:03:56]

Passes all the tests with both --nofull-codegen and --always-full-codegen on all
three platforms in release mode.

[Mads Ager (chromium), 2010-11-17 13:11:37]

LGTM

http://codereview.chromium.org/5161002/diff/1/src/arm/codegen-arm.cc
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/5161002/diff/1/src/arm/codegen-arm.cc#newcode4358
src/arm/codegen-arm.cc:4358: // a stack image common for calls using an IC
(receiver followed by
Swap the ... to follow the calling convention for call ICs?

In all the other code generators as well.

http://codereview.chromium.org/5161002/diff/1/src/ia32/codegen-ia32.cc
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/5161002/diff/1/src/ia32/codegen-ia32.cc#newcod...
src/ia32/codegen-ia32.cc:6303: Result tmp1 = frame_->Pop();
Use names like 'key' and 'receiver' instead of tmp1 and tmp2?

http://codereview.chromium.org/5161002/diff/1/src/x64/codegen-x64.cc
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/5161002/diff/1/src/x64/codegen-x64.cc#newcode5601
src/x64/codegen-x64.cc:5601: Result tmp1 = frame_->Pop();
names?

[Søren Thygesen Gjesse, 2010-11-18 08:48:57]

http://codereview.chromium.org/5161002/diff/1/src/arm/codegen-arm.cc
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/5161002/diff/1/src/arm/codegen-arm.cc#newcode4358
src/arm/codegen-arm.cc:4358: // a stack image common for calls using an IC
(receiver followed by
On 2010/11/17 13:11:37, Mads Ager wrote:
> Swap the ... to follow the calling convention for call ICs?
> 
> In all the other code generators as well.

Done.

http://codereview.chromium.org/5161002/diff/1/src/ia32/codegen-ia32.cc
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/5161002/diff/1/src/ia32/codegen-ia32.cc#newcod...
src/ia32/codegen-ia32.cc:6303: Result tmp1 = frame_->Pop();
On 2010/11/17 13:11:37, Mads Ager wrote:
> Use names like 'key' and 'receiver' instead of tmp1 and tmp2?

Done.

http://codereview.chromium.org/5161002/diff/1/src/x64/codegen-x64.cc
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/5161002/diff/1/src/x64/codegen-x64.cc#newcode5601
src/x64/codegen-x64.cc:5601: Result tmp1 = frame_->Pop();
On 2010/11/17 13:11:37, Mads Ager wrote:
> names?

Done.