Issue 516007: Rips the guts out of git-try since trychange.py is now supper awesome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 516007: Rips the guts out of git-try since trychange.py is now supper awesome. (Closed)

Created:
11 years ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, Nico, bradn

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Rips the guts out of git-try since trychange.py is now supper awesome. TEST=try me (none) BUG=none TBR=brad

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -249 lines)			Patch
	M	git-try	View		1 chunk	+16 lines, -249 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

10 years, 12 months ago (2009-12-26 03:13:36 UTC) #3

When trying to send a try job, I now get:

$ git try
Results will be emailed to: thakis@chromium.org
WARNING:root:[Errno socket error] (8, 'nodename nor servname provided, or not
known')
http://chrome-tryserver:8018/send_try_patch is unaccessible. Reason: ('socket
error', gaierror(8, 'nodename nor servname provided, or not known'))
Sorry, Tryserver is not available.

The older (apparently less awesome) version of git-try retried sending to
svn://svn.chromium.org/chrome-try/try.

Since you broke `git try` for all external contributors, it'd be awesome if you
could either fix that transparently or write a mail to chromium-dev that
explains how to work around this (looks like trychange.py reads some settings
file? I guess the default should be the externally accessible tryserver in that
case, though.)

Expand Messages | Collapse Messages