Issue 5160003: Restoring check for CHROME_HEADLESS environment variable when initializing BreakPad.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5160003: Restoring check for CHROME_HEADLESS environment variable when initializing BreakPad. (Closed)

Created:
10 years, 1 month ago by glotov

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, Mattias Nissler (ping if slow)

CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Restoring check for CHROME_HEADLESS environment variable when initializing BreakPad. BUG=chromium-os:8350 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66611

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	chrome/browser/browser_main.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mattias Nissler (ping if slow)

I cannot see why that would fix the referenced bug, but if honoring that variable ...

10 years, 1 month ago (2010-11-17 19:49:34 UTC) #3

Lei Zhang

10 years, 1 month ago (2010-11-17 19:55:18 UTC) #4

On 2010/11/17 19:49:34, Mattias Nissler wrote:
> I cannot see why that would fix the referenced bug, but if honoring that
> variable also on CrOS is what you want, then LGTM.

LGTM

On CrOS, crash reporting never gets turned on in the test environment, and
there's a test that's expecting there to be a crash dump.

Expand Messages | Collapse Messages