Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7580)

Unified Diff: chrome/browser/sync/engine/syncapi.cc

Issue 5159001: Rest of the autofill work. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Diff against the first part of the review. Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/syncapi.cc
diff --git a/chrome/browser/sync/engine/syncapi.cc b/chrome/browser/sync/engine/syncapi.cc
index 5c1ae710511252a66351ea99e9163c3a2e221071..3e52a814b9604b364ee8bbc889baf471bb2b248c 100644
--- a/chrome/browser/sync/engine/syncapi.cc
+++ b/chrome/browser/sync/engine/syncapi.cc
@@ -382,6 +382,20 @@ void WriteNode::PutAutofillSpecificsAndMarkForSyncing(
PutSpecificsAndMarkForSyncing(entity_specifics);
}
+void WriteNode::SetAutofillProfileSpecifics(
+ const sync_pb::AutofillProfileSpecifics& new_value) {
+ DCHECK_EQ(GetModelType(), syncable::AUTOFILL_PROFILE);
+ PutAutofillProfileSpecificsAndMarkForSyncing(new_value);
+}
+
+void WriteNode::PutAutofillProfileSpecificsAndMarkForSyncing(
+ const sync_pb::AutofillProfileSpecifics& new_value) {
+ sync_pb::EntitySpecifics entity_specifics;
+ entity_specifics.MutableExtension(sync_pb::autofill_profile)->CopyFrom(
+ new_value);
+ PutSpecificsAndMarkForSyncing(entity_specifics);
+}
+
void WriteNode::SetBookmarkSpecifics(
const sync_pb::BookmarkSpecifics& new_value) {
DCHECK(GetModelType() == syncable::BOOKMARKS);
@@ -2177,7 +2191,7 @@ void SyncManager::SyncInternal::OnIncomingNotification(
if (!syncable::ModelTypeBitSetFromString(
notification_data.service_specific_data,
&model_types)) {
lipalani 2010/12/08 21:37:46 this needs to go back.
- LOG(DFATAL) << "Could not extract model types from server data.";
+ // LOG(DFATAL) << "Could not extract model types from server data.";
model_types.set();
}
} else if (notification_data.service_url.empty() ||

Powered by Google App Engine
This is Rietveld 408576698