Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 5156008: Various minor bootperf improvements (Closed)

Created:
10 years, 1 month ago by jrbarnette
Modified:
9 years, 6 months ago
Reviewers:
kmixter1, sosa
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Various minor bootperf improvements Change-Id: I791fa01fcd2feb0c7b4c7e3d63cebc88d896c8ac BUG=chromium-os:9459 BUG=chromium-os:9460 TEST=run the script, and check results with showbootdata or by manually inspecting the output directory TEST=run "bootperf invalid-hostname", and see that the error message is useful Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=23de818

Patch Set 1 #

Patch Set 2 : comment improvements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M bootperf-bin/bootperf View 1 2 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jrbarnette
Trivial changes, requiring long explanations. :-/ Two of the changes are explained in the cited ...
10 years, 1 month ago (2010-11-20 23:17:21 UTC) #1
sosa
10 years, 1 month ago (2010-11-22 18:21:43 UTC) #2
LGTM w/ nit:  Can you test and fill in the TEST= stanza before committing.

Powered by Google App Engine
This is Rietveld 408576698