Changed catch-all Mac SSL OSStatus error to paramErr

Changed catch-all Mac SSL OSStatus error to paramErr.

Added net::ERR_UNEXPECTED <=> errSSLInternal mapping.

Added net::ERR_INVALID_ARGUMENT => paramErr mapping.

BUG=none
TEST=trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35650

[akalin, 2009-12-29 01:11:01]

+wtc for review

[akalin, 2010-01-05 00:41:16]

On 2009/12/29 01:11:01, akalin wrote:
> +wtc for review

ping!

[wtc, 2010-01-05 01:44:38]

Thanks for the patch!

http://codereview.chromium.org/515049/diff/1/2
File net/socket/ssl_client_socket_mac.cc (right):

http://codereview.chromium.org/515049/diff/1/2#newcode180
net/socket/ssl_client_socket_mac.cc:180: return errSSLIllegalParam;
It's better to change the catch-all error.

errSSLIllegalParam is definitely wrong.  It actually means
we received an SSL illegal_parameter alert message from the
server.  It doesn't mean "invalid function parameter".  That
error code is 'paramErr'.

I am not sure what's the right catch-all error.  I looked
at MacErrors.h.  The closest thing I can find is 'ioErr'.

I checked the Mac OS X Secure Transport source code.
errSSLInternal seems to be equivalent to our ERR_UNEXPECTED.

Please do the following:

1. Map ERR_UNEXPECTED to errSSLInternal.
2. Do not map ERR_FAILED.  Just let the default case handle
it.
3. Change the catch-all error from errSSLIllegalParam to
ioErr or paramErr.
3. If we use ioErr as the catch-all error, map ERR_INVALID_ARGUMENT to paramErr.

In some sense, it is better to use paramErr as the catch-all
error because ioErr is specifically checked by Secure Transport in two places,
so we'd need to study the Secure
Transport code to understand what it expects ioErr to mean.

[akalin, 2010-01-06 02:35:06]

On 2010/01/05 01:44:38, wtc wrote:
> Thanks for the patch!
> 
> Please do the following:
> 
> 1. Map ERR_UNEXPECTED to errSSLInternal.

Done.  I figured errSSLInternal should map to ERR_UNEXPECTED too, so I did that.

> 2. Do not map ERR_FAILED.  Just let the default case handle
> it.

Okay.

> 3. Change the catch-all error from errSSLIllegalParam to
> ioErr or paramErr.

Changed to used paramErr.  I agree that ioErr seems dangerous.

> 3. If we use ioErr as the catch-all error, map ERR_INVALID_ARGUMENT to
paramErr.

Mapped it to paramErr directly anyway, to avoid a spurious LOG(WARNING).

Please take another look.

[wtc, 2010-01-06 02:42:02]

LGTM.  Thanks!

[akalin, 2010-01-06 03:00:55]

On 2010/01/06 02:42:02, wtc wrote:
> LGTM.  Thanks!

Forgot to include CoreServices.h (for paramErr).  Did that and will submit once
trybots pass.