Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2345)

Unified Diff: chrome/browser/diagnostics/sqlite_diagnostics.cc

Issue 515033: Cleanup histogram classes mixing SetFlags into FactoryGet arguments... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_browser_application_mac_unittest.mm ('k') | chrome/browser/jankometer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/diagnostics/sqlite_diagnostics.cc
===================================================================
--- chrome/browser/diagnostics/sqlite_diagnostics.cc (revision 35277)
+++ chrome/browser/diagnostics/sqlite_diagnostics.cc (working copy)
@@ -43,11 +43,7 @@
static void RecordErrorInHistogram(int error) {
// The histogram values from sqlite result codes go currently from 1 to
// 26 currently but 50 gives them room to grow.
- static scoped_refptr<Histogram> histogram =
- LinearHistogram::LinearHistogramFactoryGet(kHistogramNames[unique], 1,
- 50, 51);
- histogram->SetFlags(kUmaTargetedHistogramFlag);
- histogram->Add(error);
+ UMA_HISTOGRAM_ENUMERATION(kHistogramNames[unique], error, 50);
}
};
« no previous file with comments | « chrome/browser/chrome_browser_application_mac_unittest.mm ('k') | chrome/browser/jankometer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698