Cleanup histogram classes mixing SetFlags into FactoryGet arguments...

chrome/browser/jankometer.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <limits>
 
 #include "chrome/browser/jankometer.h"
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
@@ skipping 74 matching lines @@
 class JankObserver : public base::RefCountedThreadSafe<JankObserver>,
                      public MessageLoopForUI::Observer {
  public:
   JankObserver(const char* thread_name,
                const TimeDelta& excessive_duration,
                bool watchdog_enable)
       : MaxMessageDelay_(excessive_duration),
         slow_processing_counter_(std::string("Chrome.SlowMsg") + thread_name),
         queueing_delay_counter_(std::string("Chrome.DelayMsg") + thread_name),
         total_time_watchdog_(excessive_duration, thread_name, watchdog_enable) {
-    process_times_ = Histogram::HistogramFactoryGet(
-        (std::string("Chrome.ProcMsgL ") + thread_name),
-        1, 3600000, 50);
-    total_times_ = Histogram::HistogramFactoryGet(
-        (std::string("Chrome.TotalMsgL ") + thread_name),
-        1, 3600000, 50);
-    process_times_->SetFlags(kUmaTargetedHistogramFlag);
-    total_times_->SetFlags(kUmaTargetedHistogramFlag);
+    process_times_ = Histogram::FactoryGet(
+        std::string("Chrome.ProcMsgL ") + thread_name,
+        1, 3600000, 50, Histogram::kUmaTargetedHistogramFlag);
+    total_times_ = Histogram::FactoryGet(
+        std::string("Chrome.TotalMsgL ") + thread_name,
+        1, 3600000, 50, Histogram::kUmaTargetedHistogramFlag);
   }
 
   // Attaches the observer to the current thread's message loop. You can only
   // attach to the current thread, so this function can be invoked on another
   // thread to attach it.
   void AttachToCurrentThread() {
     // TODO(darin): support monitoring jankiness on non-UI threads!
     if (MessageLoop::current()->type() == MessageLoop::TYPE_UI)
       MessageLoopForUI::current()->AddObserver(this);
   }
@@ skipping 154 matching lines @@
     ui_observer->Release();
     ui_observer = NULL;
   }
   if (io_observer) {
     // IO thread can't be running when we remove observers.
     DCHECK((!g_browser_process) || !(g_browser_process->io_thread()));
     io_observer->Release();
     io_observer = NULL;
   }
 }