Issue 5148002: Store script's line ends in copy-on-write fixed array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5148002: Store script's line ends in copy-on-write fixed array. (Closed)

Created:
10 years, 1 month ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Store script's line ends in copy-on-write fixed array. This allows to remove explicit copy from line ends JS accessor which is used for formatting of stack traces. Eager copying of line ends array might cause multiple full GC collections for huge scripts (e.g. scripts generated by GWT compiler with PRETY preset). Committed: http://code.google.com/p/v8/source/detail?r=5839

Patch Set 1 #

Patch Set 2 : address problems with empty fixed array #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	src/accessors.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
	M	src/handles.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages