Issue 5145009: Switch the PDF browser test to get its data from the pdf repo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5145009: Switch the PDF browser test to get its data from the pdf repo. (Closed)

Created:
10 years, 1 month ago by jam

Modified:
9 years, 7 months ago

Reviewers:
chase

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Switch the PDF browser test to get its data from the pdf repo. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66866

Patch Set 3 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -11 lines)			Patch
D	chrome/test/data/pdf_browsertest.pdf	View		Binary file		0 comments	Download
D	chrome/test/data/pdf_browsertest.png	View		Binary file		0 comments	Download
D	chrome/test/data/pdf_browsertest_scroll.png	View		Binary file		0 comments	Download
M	chrome/test/plugin/pdf_browsertest.cc	View	1 2	6 chunks	+16 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

chase

http://codereview.chromium.org/5145009/diff/3001/chrome/test/plugin/pdf_browsertest.cc File chrome/test/plugin/pdf_browsertest.cc (right): http://codereview.chromium.org/5145009/diff/3001/chrome/test/plugin/pdf_browsertest.cc#newcode59 chrome/test/plugin/pdf_browsertest.cc:59: FilePath(FILE_PATH_LITERAL("pdf/test")))); Can GetPDFTestDir() be reused here too or does ...

10 years, 1 month ago (2010-11-20 02:41:31 UTC) #2

chase

lgtm Try bot runs failed because they couldn't apply your patch..

10 years, 1 month ago (2010-11-20 02:48:55 UTC) #3

jam

10 years, 1 month ago (2010-11-20 02:51:08 UTC) #4

On Fri, Nov 19, 2010 at 6:48 PM, <chase@chromium.org> wrote:

> lgtm
>
> Try bot runs failed because they couldn't apply your patch..
>
> yeah something is wrong with the trybot since the file is at the latest
revision

>
> http://codereview.chromium.org/5145009/
>

Expand Messages | Collapse Messages

Issue 5145009: Switch the PDF browser test to get its data from the pdf repo. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages