Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 5145007: yasm 1.1 for windows for SAFESEH compatibility... (Closed)

Created:
10 years, 1 month ago by fbarchard
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

yasm 1.1 for windows for SAFESEH compatibility BUG=63567 TEST=libvpx and ffmpeg build on windows. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66803

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M README.chromium View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M binaries/win/yasm.exe View Binary file 0 comments Download

Messages

Total messages: 6 (0 generated)
fbarchard
Updated yasm for Windows and licensing (LGPL)
10 years, 1 month ago (2010-11-19 19:03:31 UTC) #1
Mark Mentovai
http://codereview.chromium.org/5145007/diff/3001/README.chromium File README.chromium (right): http://codereview.chromium.org/5145007/diff/3001/README.chromium#newcode16 README.chromium:16: http://www.tortall.net/projects/yasm/releases/yasm-1.1.0-win32.exe Are you actually checking in a binary that ...
10 years, 1 month ago (2010-11-19 19:10:43 UTC) #2
fbarchard1
http://codereview.chromium.org/5145007/diff/3001/README.chromium File README.chromium (right): http://codereview.chromium.org/5145007/diff/3001/README.chromium#newcode16 README.chromium:16: http://www.tortall.net/projects/yasm/releases/yasm-1.1.0-win32.exe yes. On http://www.tortall.net/projects/yasm/wiki/Release1.1.0 They say "For Windows and ...
10 years, 1 month ago (2010-11-19 19:53:53 UTC) #3
Mark Mentovai
If you have to check in a binary, it should at least be one you ...
10 years, 1 month ago (2010-11-19 19:55:41 UTC) #4
fbarchard1
On 2010/11/19 19:55:41, Mark Mentovai wrote: > If you have to check in a binary, ...
10 years, 1 month ago (2010-11-19 20:07:14 UTC) #5
Mark Mentovai
10 years, 1 month ago (2010-11-19 20:13:20 UTC) #6
OK, looks good then.

Powered by Google App Engine
This is Rietveld 408576698