Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 5145003: Fix a bug that caused proxy settings and language settings to be gone. (Closed)

Created:
10 years, 1 month ago by satorux1
Modified:
9 years, 7 months ago
Reviewers:
mazda
CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org, whywhat
Visibility:
Public.

Description

Fix a bug that caused proxy settings and language settings to be gone. The issue was caused by undesirable changes in r66324 probably caused by conflicts with the previous change: http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/options.html?r1=66324&r2=66323&pathrev=66324 BUG=chromium-os:9277 TEST=confirmed that the proxy settings and language settings are back Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66410

Patch Set 1 #

Patch Set 2 : remove labs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -23 lines) Patch
M chrome/browser/resources/options.html View 1 2 chunks +2 lines, -23 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
satorux1
10 years, 1 month ago (2010-11-17 08:43:30 UTC) #1
mazda
10 years, 1 month ago (2010-11-17 08:53:34 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698