Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 5144005: Converts usage of SetProp/GetProp to a map. Even after making sure we (Closed)

Created:
10 years, 1 month ago by sky
Modified:
9 years, 7 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, brettw-cc_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Attempt 2 at: Converts usage of SetProp/GetProp to a map. Even after making sure we clean up props we still leak in a handful of cases that are causing test grief. By and large our usage of properties is for inside the application, so that a map works fine. BUG=61528 44991 TEST=none TBR=cpu@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66920

Patch Set 1 #

Patch Set 2 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -138 lines) Patch
M app/app.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M app/app_base.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
A app/view_prop.h View 1 chunk +47 lines, -0 lines 0 comments Download
A app/view_prop.cc View 1 1 chunk +103 lines, -0 lines 0 comments Download
A app/view_prop_unittest.cc View 1 chunk +70 lines, -0 lines 0 comments Download
M app/win/scoped_prop.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/external_tab_container_win.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 6 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 7 chunks +15 lines, -16 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 4 chunks +4 lines, -13 lines 0 comments Download
M views/accessibility/view_accessibility.h View 1 chunk +1 line, -1 line 0 comments Download
M views/accessibility/view_accessibility.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M views/controls/native_control.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M views/controls/native_control_win.h View 3 chunks +3 lines, -5 lines 0 comments Download
M views/controls/native_control_win.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M views/focus/focus_util_win.h View 1 chunk +4 lines, -6 lines 0 comments Download
M views/focus/focus_util_win.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M views/widget/child_window_message_processor.h View 2 chunks +3 lines, -5 lines 0 comments Download
M views/widget/child_window_message_processor.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download
M views/widget/widget.h View 1 chunk +2 lines, -3 lines 0 comments Download
M views/widget/widget_gtk.h View 1 chunk +2 lines, -3 lines 0 comments Download
M views/widget/widget_gtk.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M views/widget/widget_win.h View 4 chunks +5 lines, -8 lines 0 comments Download
M views/widget/widget_win.cc View 9 chunks +22 lines, -24 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sky
10 years, 1 month ago (2010-11-19 23:26:21 UTC) #1
My first landing of this failed because of a couple of stupid typing mistakes.
The first patch here is the last patch you reviewed, the second is the fixed on.
Diff between the two to see what's changed.

I'm TBRing as the changes are trivial from what you reviewed.

  -Scott

Powered by Google App Engine
This is Rietveld 408576698