Issue 5143004: Split out the random number state between JavaScript and private API...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5143004: Split out the random number state between JavaScript and private API... (Closed)

Created:
10 years, 1 month ago by jschuh

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Split out the random number state between JavaScript and private API I've added v8::RandomPrivate() for internaly used random numbers, and pass the state in as a parameter to a random_base function. I still need to implement strong seeding. I already know how and will be landing that in another patch. BUG=http://code.google.com/p/v8/issues/detail?id=936 TEST=None.

Patch Set 1 #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -13 lines)			Patch
M	src/ia32/codegen-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform-win32.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/v8.h	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	src/v8.cc	View	1 chunk	+24 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 1 month ago (2010-11-18 08:08:22 UTC) #2

LGTM, I'll land.

http://codereview.chromium.org/5143004/diff/1/src/v8.h
File src/v8.h (right):

http://codereview.chromium.org/5143004/diff/1/src/v8.h#newcode97
src/v8.h:97: static uint32_t RandomPrivate();
We should add a comment.

Expand Messages | Collapse Messages