Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5139006: FBTF: Remove unneeded headers from base/ (part 10) (Closed)

Created:
10 years, 1 month ago by Lei Zhang
Modified:
9 years, 7 months ago
CC:
chromium-reviews, amit, stuartmorgan+watch_chromium.org, dhollowa, cbentzel+watch_chromium.org, Alpha Left Google, Erik does not do reviews, jam, apatrick_chromium, darin-cc_chromium.org, garykac, brettw-cc_chromium.org, tim (not reviewing), ben+cc_chromium.org, Raghu Simha, ncarter (slow), pam+watch_chromium.org, awong, James Hawkins, Sergey Ulanov, idana, Aaron Boodman, dmac, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

FBTF: Remove unneeded headers from base/ (part 10) BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67662

Patch Set 1 #

Patch Set 2 : fix win build #

Patch Set 3 : fix mac, cros build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -158 lines) Patch
M base/timer_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete_history_manager_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_resource_message_filter.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browsing_data_appcache_helper.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/external_metrics.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/cocoa/constrained_window_mac.h View 1 4 chunks +2 lines, -12 lines 0 comments Download
M chrome/browser/cocoa/constrained_window_mac.mm View 1 2 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/cocoa/extensions/extension_action_context_menu.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/device_orientation/provider_unittest.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/dock_info_gtk.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/file_browse_browsertest.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_devtools_manager.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_updater.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/favicon_service.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gtk/tabs/dragged_tab_gtk.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/in_process_webkit/webkit_thread.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/redirect_to_file_resource_handler.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store.cc View 1 3 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/search_engines/search_host_to_urls_map.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/service/service_process_control.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/speech/endpointer/endpointer_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_model_associator.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/data_type_manager.h View 1 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/browser/sync/glue/extension_data_type_controller_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/history_model_worker.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/password_model_associator.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/preference_data_type_controller_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_factory.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_host_manager.h View 1 2 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_manager.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/transport_security_persister.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/utility_process_host.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/worker_host/message_port_dispatcher.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/default_plugin/plugin_install_job_monitor.h View 1 3 chunks +4 lines, -9 lines 0 comments Download
M chrome/default_plugin/plugin_install_job_monitor.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/gpu/gpu_channel.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/plugin/webplugin_delegate_stub.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/notification_provider.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/service_utility_process_host.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/chrome_frame_automation.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/chrome_frame_histograms.h View 1 3 chunks +3 lines, -4 lines 0 comments Download
M chrome_frame/chrome_tab.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome_frame/test/html_util_unittests.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/urlmon_url_request.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M gfx/window_impl.h View 1 2 chunks +2 lines, -6 lines 0 comments Download
M gfx/window_impl.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager.h View 1 2 chunks +1 line, -6 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/command_buffer_service.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 1 4 chunks +2 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 4 chunks +19 lines, -2 lines 0 comments Download
M net/base/directory_lister.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/socket_stream/socket_stream.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/https_prober.h View 1 3 chunks +3 lines, -4 lines 0 comments Download
M net/url_request/url_request.h View 1 2 chunks +2 lines, -6 lines 0 comments Download
M net/url_request/url_request.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M printing/image.h View 1 3 chunks +2 lines, -9 lines 0 comments Download
M printing/image.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download
M printing/image_mac.cc View 1 chunk +1 line, -0 lines 0 comments Download
M printing/image_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/base/codec_test.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M remoting/base/decoder.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M remoting/base/decoder_row_based.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
MM remoting/base/decoder_vp8.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/capturer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/capturer_linux.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/capturer_mac.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/host/session_manager_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M views/widget/aero_tooltip_manager.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M views/window/non_client_view.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/plugins/pepper_graphics_3d.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
I think all the trybot redness is flake.
10 years, 1 month ago (2010-11-23 23:51:28 UTC) #1
Elliot Glaysher
10 years ago (2010-11-29 18:58:42 UTC) #2 
Rubber stamp. (Sorry, was on vacation)

Powered by Google App Engine
This is Rietveld 408576698