Use WebFrame::createAssociatedURLLoader....

webkit/glue/resource_fetcher.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/glue/resource_fetcher.h"
 
 #include "base/logging.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebFrame.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebKit.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebKitClient.h"
@@ skipping 28 matching lines @@
 }
 
 void ResourceFetcher::Cancel() {
   if (!completed_) {
     loader_->cancel();
     completed_ = true;
   }
 }
 
 void ResourceFetcher::Start(WebFrame* frame) {
-  WebURLRequest request(url_);
-  frame->dispatchWillSendRequest(request);
-
-  loader_.reset(WebKit::webKitClient()->createURLLoader());
-  loader_->loadAsynchronously(request, this);
+  loader_.reset(frame->createAssociatedURLLoader());
+  loader_->loadAsynchronously(WebURLRequest(url_), this);

[michaeln, 2010/12/07 00:27:32]

I wonder about ResourceFetcher resource loads now being subject to the appcache
loading logic where they aren't currently (appcache logic intentionally fails
requests for resources that are not in the cache and are not in a network
namespace). The change in behavior may trip some things up.

For example, the RenderView uses this class to load a chromeapp's manifest file.

  app_definition_fetcher_.reset(new ResourceFetcher(
      pending_app_info_->manifest_url, webview()->mainFrame(),
      NewCallback(this, &RenderView::DidDownloadApplicationDefinition)));

I'd definitely be more comfortable if we had a mode where if the resource is
avail in the appcache its utilized, but a missing resource wouldn't result in an
error... and that mode was used at this callsite.

Also, the 'mainFrame' is used in all cases when RenderView::DownloadImage is
called, do you know if DownloadImage is ever called on behalf of any other
frames?

 }
 
 /////////////////////////////////////////////////////////////////////////////
 // WebURLLoaderClient methods
 
 void ResourceFetcher::willSendRequest(
     WebURLLoader* loader, WebURLRequest& new_request,
     const WebURLResponse& redirect_response) {
 }
 
@@ skipping 60 matching lines @@
 }
 
 void ResourceFetcherWithTimeout::TimeoutFired() {
   if (!completed_) {
     loader_->cancel();
     didFail(NULL, WebURLError());
   }
 }
 
 }  // namespace webkit_glue