New heap profiler: include all heap objects and refs into snapshot.

New heap profiler: include all heap objects and refs into snapshot.

Otherwise, retaned memory sizes are not precise. This increases size
of heap snapshot, I will deal with this later. Heap objects and
references previously missing in snapshot are now marked as 'hidden'.
That means, they not shown to user, but participate in sizes
calculation.

Other small changes:
 - added 'shortcut' graph edges: e.g. to pin global objects on top
   level;
 - meta-information in JSON snapshot is no more double encoded.

Committed: http://code.google.com/p/v8/source/detail?r=5849

[Søren Thygesen Gjesse, 2010-11-18 08:14:54]

LGTM

http://codereview.chromium.org/5139002/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

http://codereview.chromium.org/5139002/diff/1/src/profile-generator.cc#newcod...
src/profile-generator.cc:1476: const uint64_t HeapObjectsMap::kGcRootsObjectId =
1;
Please add kNumReservedObjectsIds = 2 (maybe you can find a better name) and use
instead of 2 below.

http://codereview.chromium.org/5139002/diff/1/src/profile-generator.cc#newcod...
src/profile-generator.cc:1863: 
Add empty line.

http://codereview.chromium.org/5139002/diff/1/src/profile-generator.cc#newcod...
src/profile-generator.cc:1914: HeapObjectsSet* knownReferences = NULL)
knownReferences -> known_references

http://codereview.chromium.org/5139002/diff/1/src/profile-generator.h
File src/profile-generator.h (right):

http://codereview.chromium.org/5139002/diff/1/src/profile-generator.h#newcode703
src/profile-generator.h:703: static HeapObject *const kInternalRootObject;
Move * closer to HeapObject.

[mnaganov (inactive), 2010-11-18 10:32:50]

Thanks!

http://codereview.chromium.org/5139002/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

http://codereview.chromium.org/5139002/diff/1/src/profile-generator.cc#newcod...
src/profile-generator.cc:1476: const uint64_t HeapObjectsMap::kGcRootsObjectId =
1;
On 2010/11/18 08:14:54, Søren Gjesse wrote:
> Please add kNumReservedObjectsIds = 2 (maybe you can find a better name) and
use
> instead of 2 below.

OK, I've introduced kFirstAvailableObjectId.

http://codereview.chromium.org/5139002/diff/1/src/profile-generator.cc#newcod...
src/profile-generator.cc:1863: 
On 2010/11/18 08:14:54, Søren Gjesse wrote:
> Add empty line.

Done.

http://codereview.chromium.org/5139002/diff/1/src/profile-generator.cc#newcod...
src/profile-generator.cc:1914: HeapObjectsSet* knownReferences = NULL)
On 2010/11/18 08:14:54, Søren Gjesse wrote:
> knownReferences -> known_references

Done.

http://codereview.chromium.org/5139002/diff/1/src/profile-generator.h
File src/profile-generator.h (right):

http://codereview.chromium.org/5139002/diff/1/src/profile-generator.h#newcode703
src/profile-generator.h:703: static HeapObject *const kInternalRootObject;
On 2010/11/18 08:14:54, Søren Gjesse wrote:
> Move * closer to HeapObject.

Done.