Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 5136002: Extract scanner base/JS/JSON and move base and JS to scanner-base. (Closed)

Created:
10 years, 1 month ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Extract scanner base/JS/JSON and move base and JS to scanner-base. Remove templates from prescanner.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1180 lines, -1154 lines) Patch
M src/conversions.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/conversions.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/parser.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/parser.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M src/prescanner.h View 26 chunks +34 lines, -78 lines 0 comments Download
M src/scanner.h View 4 chunks +44 lines, -261 lines 0 comments Download
M src/scanner.cc View 12 chunks +73 lines, -785 lines 0 comments Download
M src/scanner-base.h View 3 chunks +304 lines, -1 line 0 comments Download
M src/scanner-base.cc View 2 chunks +713 lines, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
10 years, 1 month ago (2010-11-18 12:11:31 UTC) #1
Søren Thygesen Gjesse
10 years, 1 month ago (2010-11-18 12:33:29 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698