Issue 5131005: Add python's version in breakpad stack traces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5131005: Add python's version in breakpad stack traces (Closed)

Created:
10 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Add python's version in breakpad stack traces BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67314

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	breakpad.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

10 years, 1 month ago (2010-11-20 03:04:47 UTC) #2

lgtm

On Fri, Nov 19, 2010 at 6:50 PM, <maruel@chromium.org> wrote:

> Reviewers: John Abd-El-Malek,
>
> Description:
> Add python's version in breakpad stack traces
>
> BUG=
> TEST=
>
> Please review this at http://codereview.chromium.org/5131005/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
>
> Affected files:
>  M breakpad.py
>
>
> Index: breakpad.py
> diff --git a/breakpad.py b/breakpad.py
> index
>
f8f1a1b5aa77f95b43ef74359a157c0a9396ad4f..e6f4446b939faebc0a6d0dfdeabb94d78bd51b7b
> 100644
> --- a/breakpad.py
> +++ b/breakpad.py
> @@ -40,6 +40,7 @@ def SendStack(last_tb, stack, url=None):
>         'exception': last_tb,
>         'host': socket.getfqdn(),
>         'cwd': os.getcwd(),
> +        'version': sys.version,
>     }
>     # No exception type(s) specified
>     # pylint: disable=W0702
>
>
>

Expand Messages | Collapse Messages