Issue 5129001: Kill a #if 0 section as discussed in the meeting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5129001: Kill a #if 0 section as discussed in the meeting. (Closed)

Created:
10 years, 1 month ago by dumi

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Kill a #if 0 section as discussed in the meeting. BUG=none TEST=non Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66503

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -9 lines)			Patch
	M	ppapi/c/dev/ppb_file_ref_dev.h	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

10 years, 1 month ago (2010-11-17 04:29:38 UTC) #2

LGTM

On Tue, Nov 16, 2010 at 5:30 PM, <dumi@chromium.org> wrote:

> Reviewers: darin,
>
> Description:
> Kill a #if 0 section as discussed in the meeting.
>
> BUG=none
> TEST=non
>
>
> Please review this at http://codereview.chromium.org/5129001/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     ppapi/c/dev/ppb_file_ref_dev.h
>
>
> Index: ppapi/c/dev/ppb_file_ref_dev.h
> ===================================================================
> --- ppapi/c/dev/ppb_file_ref_dev.h      (revision 66341)
> +++ ppapi/c/dev/ppb_file_ref_dev.h      (working copy)
> @@ -75,15 +75,6 @@
>   int32_t (*Rename)(PP_Resource file_ref,
>                     PP_Resource new_file_ref,
>                     struct PP_CompletionCallback callback);
> -
> -  // TODO(darin): Add these conversion routines.
> -#if 0
> -  // Convert a DOM File object to a FileRef object.
> -  PP_Resource (*FromFileObject)(PP_Var file_object);
> -
> -  // Convert a FileRef object to a DOM File object.
> -  PP_Var (*ToFileObject)(PP_Resource file_ref);
> -#endif
>  };
>
>  #endif  // PPAPI_C_DEV_PPB_FILE_REF_DEV_H_
>
>
>

Expand Messages | Collapse Messages