Issue 5128004: Add missing Stub implementations on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5128004: Add missing Stub implementations on ARM. (Closed)

Created:
10 years, 1 month ago by Rodolph Perfetta

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add missing Stub implementations on ARM. BUG=none TEST=none Comitted as bleeding edge r5857.

Patch Set 1 #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+183 lines, -19 lines)			Patch
	M	src/arm/stub-cache-arm.cc	View		6 chunks	+183 lines, -19 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 1 month ago (2010-11-19 08:35:23 UTC) #2

LGTM

I'll fix the nit when landing.

http://codereview.chromium.org/5128004/diff/1/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/5128004/diff/1/src/arm/stub-cache-arm.cc#newco...
src/arm/stub-cache-arm.cc:1432: - kHeapObjectTag - argc * kPointerSize;
Strange indentation. Could we move the whole expression to a new line with a
four-space indent?

Expand Messages | Collapse Messages