Issue 5125003: Include the notification types being used rather than transitively....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5125003: Include the notification types being used rather than transitively.... (Closed)

Created:
10 years, 1 month ago by John Gregg

Modified:
9 years ago

Reviewers:
markusheintz_

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Include the notification types being used rather than transitively. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66627

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/browser/gtk/options/content_filter_page_gtk.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

John Gregg

these are used after your last change, but currently being pulled in via desktop_notification_service.h, which ...

10 years, 1 month ago (2010-11-18 02:33:12 UTC) #1

markusheintz_

10 years, 1 month ago (2010-11-18 09:42:13 UTC) #2

Thanks a lot for pointing this out and fixing it!

LGTM