Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 5124006: Add ability for cbuildbot to only run unit tests for revved packages. (Closed)

Created:
10 years, 1 month ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Add ability for cbuildbot to only run unit tests for revved packages. Change-Id: I6744aac09fb075f91f710f16343fab45b8dc8af9 BUG=chromium-os:7283 TEST=Ran it with cbuildbot through the unit tests phase and looked at the file and saw it get parsed correctly. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e483618

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M bin/cbuildbot.py View 4 chunks +11 lines, -2 lines 0 comments Download
M cros_mark_as_stable.py View 2 chunks +6 lines, -0 lines 0 comments Download
M cros_run_unit_tests View 2 chunks +8 lines, -5 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
sosa
10 years, 1 month ago (2010-11-22 19:54:33 UTC) #1
petkov
LGTM w/ a suggestion. Also, reading through the issue -- update_engine added a few minutes ...
10 years, 1 month ago (2010-11-22 20:05:23 UTC) #2
sosa
10 years, 1 month ago (2010-11-22 21:23:31 UTC) #3
Talked offline about this but our resolution was not to use -z because we don't
want the pfq to specify no packages but for the unit test script to interpret
this as meaning to rev all.

Powered by Google App Engine
This is Rietveld 408576698