chrome_paths: refactor and sanitize cache directory handling

chrome/common/chrome_paths_mac.mm

Index: chrome/common/chrome_paths_mac.mm
diff --git a/chrome/common/chrome_paths_mac.mm b/chrome/common/chrome_paths_mac.mm
index b87b39788ecd09ae100c4a9eef4fedc03dfdf6bb..67a687d9b9e6e06339ec6df20ccc4cb7b3361eb9 100644
--- a/chrome/common/chrome_paths_mac.mm
+++ b/chrome/common/chrome_paths_mac.mm
@@ -48,6 +48,28 @@ bool GetUserDocumentsDirectory(FilePath* result) {
   return mac_util::GetUserDirectory(NSDocumentDirectory, result);
 }
 
+bool GetUserCacheDirectory(const FilePath& profile_dir, FilePath* result) {
+  // If the profile directory is under ~/Library/Application Support,
+  // use a suitable cache directory under ~/Library/Caches.  For
+  // example, a profile directory of ~/Library/Application
+  // Support/Google/Chrome/MyProfileName would use the cache directory
+  // ~/Library/Caches/Google/Chrome/MyProfileName.
+
+  FilePath app_data_dir;
+  if (PathService::Get(base::DIR_APP_DATA, &app_data_dir)) {
+    FilePath cache_dir = cache_dir;

[Mark Mentovai, 2010/11/18 19:11:48]

Definitely not.

[Evan Martin, 2010/11/18 19:19:06]

Aw, c'mon, it's tautologically true!


*embarrassed face*

+    if (!PathService::Get(base::DIR_CACHE, &cache_dir))
+      return false;
+    if (app_data_dir.AppendRelativePath(profile_dir, &cache_dir)) {
+      *result = cache_dir;
+      return true;
+    }
+  }
+
+  *result = profile_dir;
+  return true;
+}
+
 bool GetUserDownloadsDirectory(FilePath* result) {
   return mac_util::GetUserDirectory(NSDownloadsDirectory, result);
 }